Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: Add support for Rocky Linux. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olifre
Copy link

@olifre olifre commented Dec 11, 2021

Rocky Linux is a compatible RedHat rebuild,
so COPR repository can be used too.

Rocky Linux is a compatible RedHat rebuild,
so COPR repository can be used too.
@MindTooth
Copy link

Would this also extend to AlmaLinux?

@olifre
Copy link
Author

olifre commented Sep 28, 2022

Very likely. I did not add it to the list since I do not have an AlmaLinux installation to test it on. In case you have AlmaLinux nodes and can test it works as expected, of course the list can be extended.

@MindTooth
Copy link

I have to ask, is version 7 applicable for RHEL 8? Seeing AlmaLinux/Rocky is only RHEL 8 and 9. Also, it seems wireguard-dkms is not available in RHEL 9.

kmod-wireguard can replace wireguard-dkms I believe.

I’ll be happy to test this out.

@olifre
Copy link
Author

olifre commented Oct 2, 2022

I have to ask, is version 7 applicable for RHEL 8? Seeing AlmaLinux/Rocky is only RHEL 8 and 9.

No, it isn't. My plan (in 2021) was to add a PR after this one to add support for the different versions. Since this never got merged, we did for now disable package management via this module and are using:
voxpupuli/puppet-yum#215
to set up the COPR repository on Rocky Linux 8, which works well.

kmod-wireguard can replace wireguard-dkms I believe.

It's not really a replacement, since it uses a different approach. Switching to kmod-wireguard would mean you'll have to take care of using a module-compatible kernel, while dkms compiles the module for the kernel which is in use, also allowing for custom kernels. So the price to pay is compatibility, and also adding the quite large elrepo repositories which ideally would be done via a different module.

@MindTooth
Copy link

Thank you for the explaining this stuff.


So, am I safe to assume that this would fix AlmaLInux too if that was added to be added to the list:

error during compilation: Evaluation Error: Unknown variable: 'wireguard::params::package_name'.

@olifre
Copy link
Author

olifre commented Oct 19, 2022

So, am I safe to assume that this would fix AlmaLInux too if that was added to be added to the list: [...]

With the current code, you should also get a warning such as:

warning("Unsupported OS family, couldn't configure package automatically")

The error you get should be "overridable" by configuring manually (i.e. specifying the variables manually when instantiating the module class).

If you can confirm that this works for you on Alma, or that adding Alma to the list works for you, I can of course add this change to the PR. Of course, changing the repository e.g. to COPR is still a second step to get it fully functional.

@MindTooth
Copy link

Making it work for AlmaLinux 9, we needed to set the following:

# Manual fix for making it work on AlmaLinux.
wireguard::manage_package: false
wireguard::manage_repo: false
wireguard::package_name:
  - wireguard-tools
# Dummy data
wireguard::repo_url: "https://do-not-exist.io/almalinux.rpm"

After that, we were able to utilize the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants